Re: [PATCH] range-diff: add a --no-patch option to show a summary

Hi Ævar,

On Wed, 7 Nov 2018, Johannes Schindelin wrote:

On Wed, 7 Nov 2018, Johannes Schindelin wrote:

quoted

On Tue, 6 Nov 2018, Ævar Arnfjörð Bjarmason wrote:

quoted

On Tue, Nov 06 2018, Johannes Schindelin wrote:

quoted

On Mon, 5 Nov 2018, Ævar Arnfjörð Bjarmason wrote:

quoted

On Mon, Nov 05 2018, Eric Sunshine wrote:

quoted

On Mon, Nov 5, 2018 at 3:07 PM Ævar Arnfjörð Bjarmason [off-list ref] wrote:

quoted

Add a --no-patch option which shows which changes got removed, added
or moved etc., without showing the diff associated with them.

This option existed in the very first version[1] of range-diff (then
called branch-diff) implemented by Dscho, although it was called
--no-patches (with an "es"), which it inherited from tbdiff. I think
someone (possibly me) pointed out that --no-patch (sans "es") would be
more consistent with existing Git options. I don't recall why Dscho
removed the option during the re-rolls, but the explanation may be in
that thread.

Thanks for digging. Big thread, not going to re-read it now. I'd just
like to have this.

In my hands, the well-documented `-s` option works (see e.g.
https://git-scm.com/docs/git-diff#git-diff--s), although I have to admit
that the `git-range-diff` manual does not talk about the diff-options.

And for the record, for me, `git range-diff A...B --no-patch` *already*
works.

Neither of those works for me without my patch. E.g.

    ./git-range-diff -s 711aaa392f...a5ba8f2101
    ./git-range-diff --no-patch 711aaa392f...a5ba8f2101

This is on current next, 2.19.1.1182.g4ecb1133ce. What version are you
on?

I tried it with git version 2.19.0.windows.1.

To verify, I repeated this with `next` (git version
2.19.1.1215.g8438c0b2453a):

./git range-diff -s 711aaa392f...a5ba8f2101
fatal: unrecognized argument: --output-indicator-new=>
error: could not parse log for 'a5ba8f2101..711aaa392f'

Which means that something broke rather dramatically between
v2.19.0.windows.1 and 8438c0b2453a.

Nevermind, this was solved by passing `--exec-path=$PWD`. And *now* I can
reproduce your finding.

I've bisected this breakage down to 73a834e9e279 (range-diff: relieve
callers of low-level configuration burden, 2018-07-22). Eric, that's one
of your commits.

Ciao,
Dscho