Thread (1 message) 1 message, 1 author, 2018-10-22

Re: [PATCH] fetch-pack: be more precise in parsing v2 response

From: Junio C Hamano <hidden>
Date: 2018-10-22 05:47:43
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Jonathan Tan [off-list ref] writes:
+	GIT_TRACE_PACKET="$(pwd)/log" test_must_fail git -C http_child \
+		-c protocol.version=2 \
+		fetch "$HTTPD_URL/one_time_sed/http_parent" 2> err &&
Because test_must_fail is a shell function, the above is not a
correct way to say "I want GIT_TRACE_PACKET exported only while this
thing runs".

I'll squash the following in.

 t/t5702-protocol-v2.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh
index 51009ca391..d58fbfa9e5 100755
--- a/t/t5702-protocol-v2.sh
+++ b/t/t5702-protocol-v2.sh
@@ -555,7 +555,7 @@ test_expect_success 'when server does not send "ready", expect FLUSH' '
 	printf "/acknowledgments/,$ s/0000/0001/" \
 		>"$HTTPD_ROOT_PATH/one-time-sed" &&
 
-	GIT_TRACE_PACKET="$(pwd)/log" test_must_fail git -C http_child \
+	test_must_fail env GIT_TRACE_PACKET="$(pwd)/log" git -C http_child \
 		-c protocol.version=2 \
 		fetch "$HTTPD_URL/one_time_sed/http_parent" 2> err &&
 	grep "fetch< acknowledgments" log &&
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help