Re: [PATCH] fetch-pack: be more precise in parsing v2 response

On Thu, Oct 25, 2018 at 2:04 AM Junio C Hamano [off-list ref] wrote:

Junio C Hamano [off-list ref] writes:

quoted

Jonathan Tan [off-list ref] writes:

quoted

+    GIT_TRACE_PACKET="$(pwd)/log" test_must_fail git -C http_child \
+            -c protocol.version=2 \
+            fetch "$HTTPD_URL/one_time_sed/http_parent" 2> err &&

Because test_must_fail is a shell function, the above is not a
correct way to say "I want GIT_TRACE_PACKET exported only while this
thing runs".

I'll squash the following in.

 t/t5702-protocol-v2.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh
index 51009ca391..d58fbfa9e5 100755
--- a/t/t5702-protocol-v2.sh
+++ b/t/t5702-protocol-v2.sh

@@ -555,7 +555,7 @@ test_expect_success 'when server does not send "ready", expect FLUSH' '
      printf "/acknowledgments/,$ s/0000/0001/" \
              >"$HTTPD_ROOT_PATH/one-time-sed" &&

-     GIT_TRACE_PACKET="$(pwd)/log" test_must_fail git -C http_child \
+     test_must_fail env GIT_TRACE_PACKET="$(pwd)/log" git -C http_child \
              -c protocol.version=2 \
              fetch "$HTTPD_URL/one_time_sed/http_parent" 2> err &&
      grep "fetch< acknowledgments" log &&

I know it only has been a few days, but is there any other issue
in the patch, anybody?

I have reviewed the patch and I think it is good with the squashed change above.

Thanks,
Stefan