Re: [PATCH v3 7/7] revision.c: refactor basic topo-order logic

Derrick Stolee [off-list ref] writes:

On 9/21/2018 1:39 PM, Derrick Stolee via GitGitGadget wrote:

Hello, Git contributors.

I understand that this commit message and patch are pretty
daunting. There is a lot to read and digest. I would like to see if
anyone is willing to put the work in to review this patch, as I quite
like what it does, and the performance numbers below.

I'll try to find time to review v3 of this patch series this week.

quoted

In my local testing, I used the following Git commands on the
Linux repository in three modes: HEAD~1 with no commit-graph,
HEAD~1 with a commit-graph, and HEAD with a commit-graph. This
allows comparing the benefits we get from parsing commits from
the commit-graph and then again the benefits we get by
restricting the set of commits we walk.

Test: git rev-list --topo-order -100 HEAD
HEAD~1, no commit-graph: 6.80 s
HEAD~1, w/ commit-graph: 0.77 s
   HEAD, w/ commit-graph: 0.02 s

Test: git rev-list --topo-order -100 HEAD -- tools
HEAD~1, no commit-graph: 9.63 s
HEAD~1, w/ commit-graph: 6.06 s
   HEAD, w/ commit-graph: 0.06 s

If there is something I can do to make this easier to review, then
please let me know.

Thanks,
-Stolee