Re: [PATCH 0/3] doc-diff: add "clean" mode & fix portability problem

From
Jeff King <hidden>
Date
2018-08-31 20:08:23
Reply to
Eric Sunshine, 2018-08-31
On Fri, Aug 31, 2018 at 02:33:15AM -0400, Eric Sunshine wrote:
This series replaces Peff's solo patch[1] which updates "make clean" to
remove doc-diff's temporary directory. Rather than imbuing the Makefile
with knowledge specific to doc-diff's internals, this series adds a
"clean" mode to doc-diff which removes its temporary worktree and
generated files, and has "make clean" invoke that instead. It also fixes
a portability problem which prevented doc-diff from working on MacOS and
FreeBSD.
Thanks. I left a few comments, but this looks good to me as-is.

-Peff
Thread (17 messages) 17 messages, 3 authors, last reply 2018-09-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help