Re: [PATCH] doc/Makefile: remove tmp-doc-diff on "make clean"

From
Eric Sunshine <hidden>
Date
2018-08-30 20:34:57
Reply to
Jeff King, 2018-08-30
On Thu, Aug 30, 2018 at 3:55 PM Jeff King [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The tmp-doc-diff directory isn't strictly a build product of
the Makefile, since it's only present if you manually run
the doc-diff script.  But anybody running "make clean" would
probably want it to go away.

Suggested-by: Eric Sunshine <redacted>
Signed-off-by: Jeff King <redacted>
---
diff --git a/Documentation/Makefile b/Documentation/Makefile
@@ -332,6 +332,7 @@ clean:
        $(RM) manpage-base-url.xsl
+       $(RM) -r tmp-doc-diff
Taking into consideration that people might be surprised and alarmed
to find "git worktree list" showing a worktree they didn't explicitly
create, would it make sense to do something like this?

clean:
    ...
    -git worktree remove -f tmp-doc-diff 2>/dev/null
    $(RM) -r tmp-doc-diff
Thread (17 messages) 17 messages, 3 authors, last reply 2018-09-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help