Re: [PATCH v1] msvc: fix non-standard escape sequence in source
From: Beat Bolli <hidden>
Date: 2018-07-24 18:13:13
Hi Jeff On 24.07.18 16:42, git@jeffhostetler.com wrote:
From: Jeff Hostetler <redacted> Replace non-standard "\e" escape sequence with "\x1B".
This was already fixed in [ref]. Cheers, Beat
quoted hunk ↗ jump to hunk
In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace message with several "\e" escape sequences was added. This causes a compiler warning under MSVC. According to [1], the "\e" sequence is an extension supported by GCC, clang, and tcc. [1] https://en.wikipedia.org/wiki/Escape_sequences_in_C Signed-off-by: Jeff Hostetler <redacted> --- convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/convert.c b/convert.c index 56cfe31..52092be 100644 --- a/convert.c +++ b/convert.c@@ -335,7 +335,7 @@ static void trace_encoding(const char *context, const char *path, strbuf_addf(&trace, "%s (%s, considered %s):\n", context, path, encoding); for (i = 0; i < len && buf; ++i) { strbuf_addf( - &trace,"| \e[2m%2i:\e[0m %2x \e[2m%c\e[0m%c", + &trace,"| \x1B[2m%2i:\x1B[0m %2x \x1B[2m%c\x1B[0m%c", i, (unsigned char) buf[i], (buf[i] > 32 && buf[i] < 127 ? buf[i] : ' '),