Re: [PATCH v1] msvc: fix non-standard escape sequence in source
From: Eric Sunshine <hidden>
Date: 2018-07-24 17:33:26
On Tue, Jul 24, 2018 at 10:43 AM [off-list ref] wrote:
Replace non-standard "\e" escape sequence with "\x1B". In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace message with several "\e" escape sequences was added. This causes a compiler warning under MSVC.
Wrong commit. That code was actually introduced by 541d059cd9 (convert: add tracing for 'working-tree-encoding' attribute, 2018-04-15).
quoted hunk ↗ jump to hunk
diff --git a/convert.c b/convert.c@@ -335,7 +335,7 @@ static void trace_encoding(const char *context, const char *path, strbuf_addf(&trace, "%s (%s, considered %s):\n", context, path, encoding); for (i = 0; i < len && buf; ++i) { strbuf_addf( - &trace,"| \e[2m%2i:\e[0m %2x \e[2m%c\e[0m%c", + &trace,"| \x1B[2m%2i:\x1B[0m %2x \x1B[2m%c\x1B[0m%c",
In this codebase, ESC is always spelled as octal \033 rather than hex \x1b.