[RFC PATCH 0/6] Compile cleanly in pedantic mode · Beat Bolli <hidden> · 2018-07-08
[RFC PATCH 4/6] sequencer.c: avoid empty statements at top level · Beat Bolli <hidden> · 2018-07-08
Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level · Eric Sunshine <hidden> · 2018-07-08
Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level · Philip Oakley <hidden> · 2018-07-08
Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level · <hidden> · 2018-07-09
[RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum · Beat Bolli <hidden> · 2018-07-08
Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum · Jeff King <hidden> · 2018-07-09
Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum · Beat Bolli <hidden> · 2018-07-09
Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum · Jeff King <hidden> · 2018-07-10
[RFC PATCH 3/6] convert.c: replace "\e" escapes with "\033". · Beat Bolli <hidden> · 2018-07-08
[RFC PATCH 6/6] utf8.c: avoid char overflow · Beat Bolli <hidden> · 2018-07-08
Re: [RFC PATCH 6/6] utf8.c: avoid char overflow · Johannes Schindelin <hidden> · 2018-07-09
Re: [RFC PATCH 6/6] utf8.c: avoid char overflow · Beat Bolli <hidden> · 2018-07-09
Re: [RFC PATCH 6/6] utf8.c: avoid char overflow · Beat Bolli <hidden> · 2018-07-09
Re: [RFC PATCH 6/6] utf8.c: avoid char overflow · Johannes Schindelin <hidden> · 2018-07-09
[RFC PATCH 1/6] connect.h: avoid forward declaration of an enum · Beat Bolli <hidden> · 2018-07-08
[RFC PATCH 5/6] string-list.c: avoid conversion from void * to function pointer · Beat Bolli <hidden> · 2018-07-08
Re: [RFC PATCH 0/6] Compile cleanly in pedantic mode · Johannes Schindelin <hidden> · 2018-07-09
[PATCH 0/6] Compile cleanly in pedantic mode · Beat Bolli <hidden> · 2018-07-09
Re: [PATCH 0/6] Compile cleanly in pedantic mode · Beat Bolli <hidden> · 2018-07-09
[PATCH 1/6] connect.h: avoid forward declaration of an enum · Beat Bolli <hidden> · 2018-07-09
[PATCH 5/6] string-list.c: avoid conversion from void * to function pointer · Beat Bolli <hidden> · 2018-07-09
[PATCH 3/6] convert.c: replace "\e" escapes with "\033". · Beat Bolli <hidden> · 2018-07-09
[PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum · Beat Bolli <hidden> · 2018-07-09
[PATCH 6/6] utf8.c: avoid char overflow · Beat Bolli <hidden> · 2018-07-09
[PATCH 4/6] sequencer.c: avoid empty statements at top level · Beat Bolli <hidden> · 2018-07-09

Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum

From: Jeff King <hidden>
Date: 2018-07-10 02:16:04

On Mon, Jul 09, 2018 at 09:30:12PM +0200, Beat Bolli wrote:

quoted

Other than this minor quibble, the whole series looks good to me, modulo
the existing review.

Ooosp, I've just sent the non-RFC reroll without this change.

Junio, would you squash this into [1/6] and [2/6], please (if you agree,
of course :-)

:) I'd be happy with that squash, but not the end of the world if it
doesn't make it. Thanks for the whole series.

-Peff

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help