[RFC PATCH 6/6] utf8.c: avoid char overflow
From: Beat Bolli <hidden>
Date: 2018-07-08 14:44:17
Subsystem:
the rest · Maintainer:
Linus Torvalds
In ISO C, char constants must be in the range -128..127. Change the BOM constants to unsigned char to avoid overflow. Signed-off-by: Beat Bolli <redacted> --- utf8.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/utf8.c b/utf8.c
index d55e20c641..833ce00617 100644
--- a/utf8.c
+++ b/utf8.c@@ -561,15 +561,15 @@ char *reencode_string_len(const char *in, int insz, #endif static int has_bom_prefix(const char *data, size_t len, - const char *bom, size_t bom_len) + const unsigned char *bom, size_t bom_len) { return data && bom && (len >= bom_len) && !memcmp(data, bom, bom_len); } -static const char utf16_be_bom[] = {0xFE, 0xFF}; -static const char utf16_le_bom[] = {0xFF, 0xFE}; -static const char utf32_be_bom[] = {0x00, 0x00, 0xFE, 0xFF}; -static const char utf32_le_bom[] = {0xFF, 0xFE, 0x00, 0x00}; +static const unsigned char utf16_be_bom[] = {0xFE, 0xFF}; +static const unsigned char utf16_le_bom[] = {0xFF, 0xFE}; +static const unsigned char utf32_be_bom[] = {0x00, 0x00, 0xFE, 0xFF}; +static const unsigned char utf32_le_bom[] = {0xFF, 0xFE, 0x00, 0x00}; int has_prohibited_utf_bom(const char *enc, const char *data, size_t len) {
--
2.15.0.rc1.299.gda03b47c3