Re: [PATCH v4 2/6] sha1-array.h: align function arguments

[PATCH 0/9] get_short_oid UI improvements · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 1/9] sha1-name.c: remove stray newline · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 2/9] sha1-array.h: align function arguments · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 3/9] sha1-name.c: move around the collect_ambiguous() function · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 4/9] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
Re: [PATCH 4/9] get_short_oid: sort ambiguous objects by type, then SHA-1 · Derrick Stolee <hidden> · 2018-05-01
Re: [PATCH 4/9] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH 4/9] get_short_oid: sort ambiguous objects by type, then SHA-1 · Derrick Stolee <hidden> · 2018-05-01
Re: [PATCH 4/9] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH 4/9] get_short_oid: sort ambiguous objects by type, then SHA-1 · Derrick Stolee <hidden> · 2018-05-01
[PATCH 6/9] get_short_oid: learn to disambiguate by ^{blob} · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 7/9] get_short_oid / peel_onion: ^{tree} should mean tree, not treeish · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
Re: [PATCH 7/9] get_short_oid / peel_onion: ^{tree} should mean tree, not treeish · brian m. carlson <hidden> · 2018-05-01
[PATCH 5/9] get_short_oid: learn to disambiguate by ^{tag} · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 9/9] config doc: document core.disambiguate · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
[PATCH 8/9] get_short_oid / peel_onion: ^{tree} should mean commit, not commitish · Ævar Arnfjörð Bjarmason <hidden> · 2018-04-30
Re: [PATCH 8/9] get_short_oid / peel_onion: ^{tree} should mean commit, not commitish · Eric Sunshine <hidden> · 2018-04-30
Re: [PATCH 0/9] get_short_oid UI improvements · Stefan Beller <hidden> · 2018-04-30
Re: [PATCH 0/9] get_short_oid UI improvements · brian m. carlson <hidden> · 2018-05-01
Re: [PATCH 0/9] get_short_oid UI improvements · Derrick Stolee <hidden> · 2018-05-01
[PATCH v2 00/12] get_short_oid UI improvements · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 01/12] sha1-name.c: remove stray newline · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 02/12] sha1-array.h: align function arguments · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 03/12] git-p4: change "commitish" typo to "committish" · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 04/12] cache.h: add comment explaining the order in object_type · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 05/12] sha1-name.c: move around the collect_ambiguous() function · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 07/12] get_short_oid: learn to disambiguate by ^{tag} · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 06/12] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 09/12] get_short_oid / peel_onion: ^{tree} should be tree, not treeish · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 10/12] get_short_oid / peel_onion: ^{commit} should be commit, not committish · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 12/12] get_short_oid: document & warn if we ignore the type selector · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 11/12] config doc: document core.disambiguate · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 08/12] get_short_oid: learn to disambiguate by ^{blob} · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v2 06/11] get_short_oid: sort ambiguous objects by type, then SHA-1 · Derrick Stolee <hidden> · 2018-05-01
Re: [PATCH v2 06/11] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH v2 06/11] get_short_oid: sort ambiguous objects by type, then SHA-1 · Derrick Stolee <hidden> · 2018-05-01
Re: [PATCH v2 06/11] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH v2 06/11] get_short_oid: sort ambiguous objects by type, then SHA-1 · Derrick Stolee <hidden> · 2018-05-01
[PATCH v3 00/12] get_short_oid UI improvements · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 01/12] sha1-name.c: remove stray newline · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 02/12] sha1-array.h: align function arguments · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 04/12] cache.h: add comment explaining the order in object_type · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH v3 04/12] cache.h: add comment explaining the order in object_type · Duy Nguyen <hidden> · 2018-05-08
[PATCH] pack-format.txt: more details on pack file format · Nguyễn Thái Ngọc Duy <hidden> · 2018-05-08
Re: [PATCH] pack-format.txt: more details on pack file format · Stefan Beller <hidden> · 2018-05-08
Re: [PATCH] pack-format.txt: more details on pack file format · Duy Nguyen <hidden> · 2018-05-08
Re: [PATCH] pack-format.txt: more details on pack file format · Stefan Beller <hidden> · 2018-05-08
Re: [PATCH] pack-format.txt: more details on pack file format · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-08
Re: [PATCH] pack-format.txt: more details on pack file format · Duy Nguyen <hidden> · 2018-05-08
[PATCH v2] pack-format.txt: more details on pack file format · Nguyễn Thái Ngọc Duy <hidden> · 2018-05-10
Re: [PATCH v2] pack-format.txt: more details on pack file format · Stefan Beller <hidden> · 2018-05-10
Re: [PATCH v2] pack-format.txt: more details on pack file format · Duy Nguyen <hidden> · 2018-05-11
[PATCH v3] pack-format.txt: more details on pack file format · Nguyễn Thái Ngọc Duy <hidden> · 2018-05-11
[PATCH v3 03/12] git-p4: change "commitish" typo to "committish" · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 05/12] sha1-name.c: move around the collect_ambiguous() function · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 08/12] get_short_oid: learn to disambiguate by ^{blob} · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 09/12] get_short_oid / peel_onion: ^{tree} should be tree, not treeish · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v4 0/6] get_short_oid UI improvements · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
[PATCH v4 1/6] sha1-name.c: remove stray newline · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
[PATCH v4 2/6] sha1-array.h: align function arguments · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
Re: [PATCH v4 2/6] sha1-array.h: align function arguments · Jeff King <hidden> · 2018-05-10
[PATCH v4 3/6] git-p4: change "commitish" typo to "committish" · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
Re: [PATCH v4 3/6] git-p4: change "commitish" typo to "committish" · Luke Diamand <hidden> · 2018-05-10
[PATCH v4 4/6] sha1-name.c: move around the collect_ambiguous() function · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
[PATCH v4 5/6] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
Re: [PATCH v4 5/6] get_short_oid: sort ambiguous objects by type, then SHA-1 · Jeff King <hidden> · 2018-05-10
[PATCH v4 6/6] get_short_oid: document & warn if we ignore the type selector · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-10
Re: [PATCH v4 6/6] get_short_oid: document & warn if we ignore the type selector · Martin Ågren <hidden> · 2018-05-10
Re: [PATCH v4 6/6] get_short_oid: document & warn if we ignore the type selector · Jeff King <hidden> · 2018-05-10
Re: [PATCH v4 6/6] get_short_oid: document & warn if we ignore the type selector · Jeff King <hidden> · 2018-05-10
Re: [PATCH v4 6/6] get_short_oid: document & warn if we ignore the type selector · Jeff King <hidden> · 2018-05-10
Re: [PATCH v4 0/6] get_short_oid UI improvements · Jeff King <hidden> · 2018-05-10
[PATCH v3 10/12] get_short_oid / peel_onion: ^{commit} should be commit, not committish · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 11/12] config doc: document core.disambiguate · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH v3 11/12] config doc: document core.disambiguate · Jeff King <hidden> · 2018-05-08
[PATCH v3 12/12] get_short_oid: document & warn if we ignore the type selector · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
[PATCH v3 06/12] get_short_oid: sort ambiguous objects by type, then SHA-1 · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH v3 06/12] get_short_oid: sort ambiguous objects by type, then SHA-1 · Jeff King <hidden> · 2018-05-08
[PATCH v3 07/12] get_short_oid: learn to disambiguate by ^{tag} · Ævar Arnfjörð Bjarmason <hidden> · 2018-05-01
Re: [PATCH v3 00/12] get_short_oid UI improvements · Derrick Stolee <hidden> · 2018-05-02
Re: [PATCH v3 00/12] get_short_oid UI improvements · Derrick Stolee <hidden> · 2018-05-02
Re: [PATCH v3 00/12] get_short_oid UI improvements · Jacob Keller <hidden> · 2018-05-03

From: Jeff King <hidden>
Date: 2018-05-10 15:06:27

On Thu, May 10, 2018 at 12:42:59PM +0000, Ævar Arnfjörð Bjarmason wrote:

The arguments weren't lined up with the opening parenthesis. Fixes up
code added in aae0caf19e ("sha1-array.h: align function arguments",
2018-04-30).

I think that's this patch. :)

Presumably you meant 910650d2f8 (Rename sha1_array to oid_array,
2017-03-31)?

-Peff

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help