Re: [PATCH v3 00/12] get_short_oid UI improvements
From: Jacob Keller <hidden>
Date: 2018-05-03 06:43:49
From: Jacob Keller <hidden>
Date: 2018-05-03 06:43:49
On Wed, May 2, 2018 at 6:45 AM, Derrick Stolee [off-list ref] wrote:
On 5/2/2018 8:42 AM, Derrick Stolee wrote:quoted
On 5/1/2018 2:40 PM, Ævar Arnfjörð Bjarmason wrote:quoted
The biggest change in v3 is the no change at all to the code, but a lengthy explanation of why I didn't go for Derrick's simpler implementation. Maybe I'm wrong about that, but I felt uneasy offloading undocumented (or if I documented it, it would only be for this one edge-case) magic on the oid_array API. Instead I'm just making this patch a bit more complex.I think that's fair. Thanks for going along with me on the thought experiment.Also, v3 looks good to me. Reviewed-by: Derrick Stolee <redacted>
I also reviewed this, and it looks good to me as well. Thanks, Jake