Thread (12 messages) 12 messages, 4 authors, 2018-05-01

Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

From: Duy Nguyen <hidden>
Date: 2018-05-01 11:26:47

On Mon, Apr 30, 2018 at 12:17 AM, Johannes Schindelin
[off-list ref] wrote:
t1406 specifically verifies that certain code paths fail with a BUG: ...
message.

In the upcoming commit, we will convert that message to be generated via
BUG() instead of die("BUG: ..."), which implies SIGABRT instead of a
regular exit code.
On the other hand, SIGABRT on linux creates core dumps. And on some
setup (like mine) core dumps may be redirected to some central place
via /proc/sys/kernel/core_pattern. I think systemd does it too but I
didn't check.

This moving to SIGABRT when we know it _will_ happen when running the
test suite will accumulate core dumps over time and not cleaned up by
the test suite. Maybe keeping die("BUG: here is a good compromise.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help