Re: [PATCH 6/6] Convert remaining die*(BUG) messages
From: Eric Sunshine <hidden>
Date: 2018-04-30 02:53:11
From: Eric Sunshine <hidden>
Date: 2018-04-30 02:53:11
On Sun, Apr 29, 2018 at 6:19 PM, Johannes Schindelin [off-list ref] wrote:
These were not caught by the previous commit, as they did not match the regular expression. Signed-off-by: Johannes Schindelin <redacted> ---diff --git a/submodule.c b/submodule.c@@ -2043,7 +2043,7 @@ const char *get_superproject_working_tree(void) if (super_sub_len > cwd_len || strcmp(&cwd[cwd_len - super_sub_len], super_sub)) - die (_("BUG: returned path string doesn't match cwd?")); + BUG("returned path string doesn't match cwd?");
This message used to be localizable but no longer is, which makes sense since it's not intended as a user-facing error message but rather is meant for Git developers. Good.