Thread (15 messages) flat view 15 messages, 4 authors, 2018-03-19

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

From: Daniel Jacques <hidden>
Date: 2018-03-19 22:07:22

On Mon, Mar 19, 2018 at 5:32 PM Martin Ågren [off-list ref] wrote:
This commit message mentions RUNTIME_PREFIX_PERL twice, but there is no
use of RUNTIME_PREFIX_PERL in the actual diffs (patches 1-3/3). Should
it be s/_PERL//? Your cover letter hints as much under "Changes in v6
from v5". And "Add a new Makefile flag ..." would need some more
rewriting since this patch rather expands the scope of the existing
flag?
Thanks for pointing this out - the two were separate flags in my original
patch set because I
wanted to minimize the scope of impact; however, I have since received
advice and buy-in
on converging them and RUNTIME_PREFIX_PERL functionality was merged
underneath
of RUNTIME_PREFIX in this latest patch set.

I'll update the commit message!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help