Thread (15 messages) flat view 15 messages, 4 authors, 2018-03-19

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

From: Martin Ågren <hidden>
Date: 2018-03-19 21:32:46

On 19 March 2018 at 03:50, Dan Jacques [off-list ref] wrote:
Add a new Makefile flag, RUNTIME_PREFIX_PERL, which, when enabled,
configures Perl scripts to locate the Git installation's Perl support
libraries by resolving against the script's path, rather than
hard-coding that path at build-time.

RUNTIME_PREFIX_PERL requires that system paths are expressed relative to
This commit message mentions RUNTIME_PREFIX_PERL twice, but there is no
use of RUNTIME_PREFIX_PERL in the actual diffs (patches 1-3/3). Should
it be s/_PERL//? Your cover letter hints as much under "Changes in v6
from v5". And "Add a new Makefile flag ..." would need some more
rewriting since this patch rather expands the scope of the existing
flag?
a common installation directory, and uses that relationship to locate
support files based on the known starting point of the script being
executed, much like RUNTIME_PREFIX does for the Git binary.
With s/_PERL//, this part above reads a bit odd. Would this be
s/RUNTIME_PREFIX/it/?

Martin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help