Re: [PATCH v3 2/7] gc: add --keep-base-pack
From: Duy Nguyen <hidden>
Date: 2018-03-19 17:27:20
On Fri, Mar 16, 2018 at 10:05 PM, Ævar Arnfjörð Bjarmason [off-list ref] wrote:
On Fri, Mar 16 2018, Nguyễn Thái Ngọc Duy jotted:quoted
+--keep-base-pack:: + All packs except the base pack and those marked with a `.keep` + files are consolidated into a single pack. The largest pack is + considered the base pack. +I wonder if all of this would be less confusing as:quoted
+--keep-biggest-pack:: + All packs except the largest pack and those marked with a `.keep` + files are consolidated into a single pack.I.e. just skimming these docs I'd expect "base" to somehow be the thing that we initially cloned, of course in almost all cases that *is* the largest pack, but not necessarily. So rather than communicate that expectation let's just say largest/biggest?
Keeping the term base pack allows us to change its definition later (something else other than "largest"). But to be honest I can't see what else can a base pack(s) be. So unless people object I'm changing this to --keep-biggest-pack (which could take a value <N> to keep <N> largest packs, but I will refrain from doing things we don't need right now).
Maybe I'm the only one who finds this confusing...
-- Duy