Re: [PATCHv4 00/27] Moving global state into the repository object (part 1)
From: Duy Nguyen <hidden>
Date: 2018-02-27 00:03:15
On Tue, Feb 27, 2018 at 3:50 AM, Stefan Beller [off-list ref] wrote:
quoted
The natural thing to do is move these to raw_object_store too (and repo_submodule_init needs to check submodule's config file). But one may argue these should be per-process instead of per-repo though. I don't know. But I thought I should mention this.For now a process and a repository is the same as git-gc or git-repack
I think you're thinking about the pack writing part, but these are configuration for pack reading (aka "object store"). If you read a blob from a submodule (e.g. git-grep), you'll use these configurations at some point. There are of course more configuration for pack writing (like zlib_compression_level) which I deliberately avoided to mention because I don't even know where they belong.
doesn't know about the --recurse-submodules flag, yet. I wonder if we ever want to teach those commands the submodule recursion, because of the issue you bring up, which settings do we apply for a submodule? Traditionally we'd just have the command line override the configuration, which I don't know if it is a good idea for these settings.
-- Duy