Re: [PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter

On Wed, Feb 07, 2018 at 02:53:17PM +0100, SZEDER Gábor wrote:

quoted

The "too old" curl is older than 7.19.4, which we actually fail to build
with since v2.12.0. So they probably did not even get as far as the
tests. ;)

Oh, OK, I was not aware of that.  The oldest non-maintenance release
with the missing filename parameter is v2.7.0, so that's still a 5
releases time frame to notice it.

Actually, I'm wrong. It looks like we did finally fix it in f18777ba6e
(http: fix handling of missing CURLPROTO_*, 2017-08-11), which is in
v2.15. So:

Anyway, I'm preparing v2 of this series, and I'm not sure what to do
about this.

  - Should I simply drop the "your curl version is too old" pattern?  It
    would make sense, but it just doesn't feel quite right to remove it
    while the corresponding printf() is still there, even if it can't be
    triggered anymore.  However, cleaning up the curl version checks in
    http.c to remove this message is beyond the scope of this patch
    series.

  - Or leave it almost-as-is, only dropping the now unnecessary curly
    braces as Simon pointed out.  And perhaps a bit of update to the
    commit message.

I'd prefer the second option.

Yeah, I think just leave it as-is. Thanks.

-Peff