Re: [PATCH 10/10] t: make 'test_i18ngrep' more informative on failure

On Fri, Jan 26, 2018 at 7:50 PM, Jeff King [off-list ref] wrote:

On Fri, Jan 26, 2018 at 01:37:08PM +0100, SZEDER Gábor wrote:

quoted

When 'test_i18ngrep' can't find the expected pattern, it exits
completely silently; when its negated form does find the pattern that
shouldn't be there, it prints the matching line(s) but otherwise exits
without any error message.  This leaves the developer puzzled about
what could have gone wrong.

Make 'test_i18ngrep' more informative on failure by printing an error
message including the invoked 'grep' command and the contents of the
file it had to scan through.

I think this is an improvement. You can also use "-x" to get a better
sense of exactly which command failed,

Yeah, I know...  but I have some issues with running tests with '-x'; I
suspect PEBKAC, but haven't yet got around to investigate.