Thread (17 messages) flat view 17 messages, 6 authors, 2018-01-23

Re: SQUASH convert: add tracing for 'working-tree-encoding' attribute

From: Eric Sunshine <hidden>
Date: 2018-01-22 19:37:52

On Mon, Jan 22, 2018 at 1:00 PM,  [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/convert.c b/convert.c
@@ -1165,8 +1165,9 @@ static struct encoding *git_path_check_encoding(struct attr_check_item *check)
-       enc = xcalloc(1, sizeof(struct convert_driver));
-       enc->name = xstrdup_toupper(value);  /* aways use upper case names! */
+       enc = xcalloc(1, sizeof(*enc));
+       /* Aways use upper case names to simplify subsequent string comparison. */
s/Aways/Always/

https://public-inbox.org/git/20180121142222.GA10248@ruderich.org/
+       enc->name = xstrdup_toupper(value);
        *encoding_tail = enc;
        encoding_tail = &(enc->next);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help