Thread (11 messages) flat view 11 messages, 4 authors, 2017-12-14

Re: [PATCH v3] git-gui: Prevent double UTF-8 conversion

From: Johannes Schindelin <hidden>
Date: 2017-12-07 00:07:20

Hi Łukasz,

On Tue, 5 Dec 2017, Łukasz Stelmach wrote:
Convert author's name and e-mail address from the UTF-8 (or any other)
encoding in load_last_commit function the same way commit message is
converted.

Amending commits in git-gui without such conversion breaks UTF-8
strings. For example, "\305\201ukasz" (as written by git cat-file) becomes
"\303\205\302\201ukasz" in an amended commit.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
This patch looks good to me.

Thanks,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help