Re: [PATCH] git-gui: Prevent double UTF-8 conversion

Hi Łukasz,

On Tue, 28 Nov 2017, Łukasz Stelmach wrote:

Set encoding to utf-8 for file descriptors used to receive data from git
commands.

The patch only changes it for the `cat-file` command used to read the
latest commit message for amending.

Maybe the commit message should be adjusted to reflect as much?

With encoding on the file descriptor set to "binary" Tcl (8.6 in my
case) does double conversion which breaks e.g. author name in amended
commits.

Is the problem in question occurring when a commit message contains
non-ASCII characters encoded in UTF-8 and you click the "Amend Last
Commit" radio button on the right side above the "Commit Message" text
box?

I tested this with Tcl/Tk 8.6.7-1 of Git for Windows' SDK, and with Tcl/Tk
8.6.0+9 of Ubuntu 16.04.3 LTS, in both cases the encoding of a commit
message 'äöü' was handled correctly with "binary"...

Could you give more details about your system so it is easier for me to
understand where the difference comes from?

Having said that, I also tested it *with* your patch, and it does not
break anything.

So, this is the second attempt to draw some attention to this patch,
since the first one has somewhat failed.

Yeah, sadly Pat (who is still listed as the active Git GUI maintainer) has
fallen very, very silent for over a year.

Pinging about the status of the patch was definitely the right thing to
do.

Ciao,
Johannes