Thread (17 messages) flat view 17 messages, 4 authors, 2017-12-05

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Dan Jacques <hidden>
Date: 2017-12-01 18:19:16

On Fri, 1 Dec 2017, Johannes Sixt wrote:
quoted
quoted
This doesn't work, unfortunately. When $(pathsep) is ';', we get an
incomplete sed expression because ';' is also a command separator in the sed language.
Funny, I tried this also with ';' as pathsep, and it worked in the Git for
Windows SDK...
My ancient sed vs. your modern sed, perhaps? I can check this on Monday.
If you wouldn't mind, that would be much appreciated. Did you actually observe
this issue, or is it just coming up in review?

I am not a `sed` wizard, but perhaps the tool is ignoring the semicolon because
it's in the middle of the "s" expression? The shell may similarly be ignoring it
because it's nested in between single-quotes?

-Dan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help