Thread (13 messages) flat view 13 messages, 5 authors, 2017-11-30

Re: [PATCH v5 4/6] list-objects: filter objects in traverse_commit_list

From: Stefan Beller <hidden>
Date: 2017-11-22 22:56:53

On Tue, Nov 21, 2017 at 12:58 PM, Jeff Hostetler [off-list ref] wrote:
+       assert(arg);
+       assert(!unset);
I count 16 asserts in this patch. Is that really needed?
Either omit them or use BUG if we want to rely on user
bug reports when these conditions trigger, as assert is unreliable
due to its dependence on the NDEBUG flag.

Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help