Re: [PATCH v5 0/6] Partial clone part 1: object filtering

On Tue, 21 Nov 2017 20:58:46 +0000
Jeff Hostetler [off-list ref] wrote:

From: Jeff Hostetler <redacted>

Here is V5 of the list-object filtering, rev-list, and pack-objects.

This version addresses comments on the V4 series.  I removed the
questionable character encoding scheme.  And I removed or clarified
use of the term "partial clone" to refer to a future feature.

Jeff Hostetler (6):
  dir: allow exclusions from blob in addition to file
  oidmap: add oidmap iterator methods
  oidset: add iterator methods to oidset
  list-objects: filter objects in traverse_commit_list
  rev-list: add list-objects filtering support
  pack-objects: add list-objects filtering

I checked the diff against v4 and this looks good.

I'm still unsure if pre-parsing the --filter argument into a struct
list_objects_filter_options is the best approach API-wise in the case
that we plan to send it to the server, but it does have the benefit of
failing (and informing the user) early if the filter is in the wrong
format, so I'm fine with this patch set as-is.