Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On 11/3/2017 7:54 AM, Johannes Schindelin wrote:

Hi Jonathan,

On Thu, 2 Nov 2017, Jonathan Tan wrote:

quoted

On Thu,  2 Nov 2017 17:50:11 +0000
Jeff Hostetler [off-list ref] wrote:

quoted

+int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
+			      const char *arg)

Returning void is fine, I think. It seems that all your code paths
either return 0 or die.

Can we please start to encourage libified code, rather than discourage it?

I did that so that I could call it from the opt_parse_... version below
it that is used by the OPT_ macros.

And Johannes is right, it bothers me that there doesn't seem to be a hard
line where one should or should not call die() vs returning an error code.

Jeff