Thread (15 messages) flat view 15 messages, 3 authors, 2017-11-07

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

From: Johannes Schindelin <hidden>
Date: 2017-11-03 11:55:45

Hi Jonathan,

On Thu, 2 Nov 2017, Jonathan Tan wrote:
On Thu,  2 Nov 2017 17:50:11 +0000
Jeff Hostetler [off-list ref] wrote:
quoted
+int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
+			      const char *arg)
Returning void is fine, I think. It seems that all your code paths
either return 0 or die.
Can we please start to encourage libified code, rather than discourage it?

Thank you,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help