Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

On Sun, Oct 29, 2017 at 10:43 PM, Antoine Beaupré [off-list ref] wrote:

On 2017-10-29 15:49:28, Eric Sunshine wrote:

quoted

This may be problematic since get_mw_namespace_id() may return undef
rather than a number, in which case Perl will complain.

Actually, get_mw_namespace_id() doesn't seem like it can return undef -
did you mistake it with get_mw_namespace_id_for_page()?

Hmm, no. What I see in the function is this:

    my $id;
    ...
    if ($ns->{is_namespace}) {
        $id = $ns->{id};
    }
    ...
    return $id;

So, $id starts undefined and is assigned only conditionally before
being returned, but perhaps I'm missing some subtlety.