Thread (93 messages) flat view 93 messages, 11 authors, 2017-09-24

Re: [PATCH v7 02/12] preload-index: add override to enable testing preload-index

From: Stefan Beller <hidden>
Date: 2017-09-21 00:44:28

To execute the preload code path, we need a minimum of 2 cache entries and 2
threads so that each thread actually has work to do.  Otherwise the logic
below that divides the work up would need to be updated as well.  The
additional complexity didn't seem worth it just to enable the code path to
execute with a single thread on a single cache entry.
[snip]
That would require a larger patch that would update the work division and
thread creation logic for little to no gain.
Oh I was not aware of the additional needed refactoring. (I assumed that
would *just work*, experience should have told me to have a look first).
There are no new tests that take advantage of this new environment variable.
Instead you can run the entire git test suite with it by running:

GIT_FORCE_PRELOAD_TEXT=1 prove -j12 --state=all ./t[0-9]*.sh

I can add that to the commit message to make it more obvious if desired.
it would have helped me being less confused as there was an "obvious"
easier and more correct alternative, which you just explained
is neither easier nor more correct as we probably do not desire that
anyway.

Thanks,
Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help