Re: [PATCH 1/3] trailers: create struct trailer_opts
From: Jonathan Tan <hidden>
Date: 2017-07-12 21:19:13
On Wed, 12 Jul 2017 15:46:44 +0200 Paolo Bonzini [off-list ref] wrote:
-static void print_all(FILE *outfile, struct list_head *head, int trim_empty) +static void print_all(FILE *outfile, struct list_head *head, + struct trailer_opts *opts)
This can be "const struct trailer_opts *", I think. (Same for the other functions in this patch.)
+struct trailer_opts {
+ int in_place;
+ int trim_empty;
+};I was going to suggest that you make these "unsigned in_place : 1" etc., but I think OPT_BOOL doesn't support those. (And OPT_BIT is probably not worth it.)