Thread (10 messages) flat view 10 messages, 4 authors, 2017-07-12

Re: [PATCH 0/3] interpret-trailers: add --where, --if-exists, --if-missing

From: Christian Couder <hidden>
Date: 2017-07-12 14:47:16

On Wed, Jul 12, 2017 at 3:46 PM, Paolo Bonzini [off-list ref] wrote:
These options are useful to experiment with "git interpret-trailers"
without having to tinker with .gitconfig.  It can also be useful in the
oddball case where you want a different placement for the trailer.

The case that stimulated the creation of the patches was configuring

     trailer.signed-off-by.where = end

and then wanting "--where before" when a patch author forgets his
Signed-off-by and provides it in a separate email.
Maybe you could have used the following to temporarily override the config:

git -c trailer.signed-off-by.where=before interpret-trailers ...

But it could be helpful and more straightforward to provide the
options you implemented.

I am not sure also if --where should override both "trailer.where" and
"trailer.<token>.where", or if should just override the former.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help