Re: [PATCH v4 2/4] diff: have the diff-* builtins configure diff before initializing revisions

On 2017-05-08 11:22 PM, Jeff King wrote:

On Mon, May 08, 2017 at 12:03:37PM -0400, Marc Branchaud wrote:

quoted

This matches how the diff Porcelain works.  It makes the plumbing commands
respect diff's configuration options, such as indentHeuristic, because
init_revisions() calls diff_setup() which fills in the diff_options struct.

I don't know if you want to note here that this is only _some_ options.
I.e., ones that we handle by copying via diff_setup(). Maybe it's
obvious from the description already (it's hard for me to tell because I
already know it either way :) ).

(shrug)  I'm fine with the way it is, but I'd also be OK with "respect 
some of diff's configuration options".

Junio, please feel free to reword the message if you like.  Or I can 
send out a v5, if that's easier for you.

		M.