Re: [PATCH v4 4/4] add--interactive: drop diff.indentHeuristic handling
From: Jeff King <hidden>
Date: 2017-05-09 03:30:07
On Mon, May 08, 2017 at 12:03:39PM -0400, Marc Branchaud wrote:
quoted hunk ↗ jump to hunk
@@ -730,9 +729,6 @@ sub parse_diff { if (defined $diff_algorithm) { splice @diff_cmd, 1, 0, "--diff-algorithm=${diff_algorithm}"; } - if ($diff_indent_heuristic) { - splice @diff_cmd, 1, 0, "--indent-heuristic"; - }
I don't remember if I mentioned this before, but this series (and the reasoning why it is OK to tweak the default) did make me wonder if it be reasonable to respect diff.algorithm even in plumbing. I don't actually use it myself, and certainly it would not need to be part of this series. But perhaps if somebody is really into alternate diff algorithms they'd be interested in following it up (my own experience with alternate algorithms has usually been "wow, this diff is ugly; I wonder if --patience helps" followed by "nope, still ugly"). -Peff