Thread (37 messages) flat view 37 messages, 3 authors, 2017-04-24

Re: [PATCH v3 2/4] refs: introduce get_worktree_ref_store()

From: Duy Nguyen <hidden>
Date: 2017-03-26 08:27:15

On Mon, Mar 20, 2017 at 9:25 PM, Michael Haggerty [off-list ref] wrote:
Instead of moving all of the `for_each_*_submodule()` functions over, I
encourage you to consider getting rid of them entirely and let the
end-users call the `refs_for_each_*()` versions of the functions. Again,
I'm not sure that there won't be friction in doing so, but it seems like
it's worth a try.
They are getting rid of. If you look at pu (or nd/prune-in-worktree
actually) there's only head_ref_submodule() and
for_each_remote_ref_submodule() left. head_ref_submodule() has no
caller but is still there, I'll need to kill it. Killing the latter
can be done separately since the callers in submodule.c need some
update.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help