Thread (37 messages) flat view 37 messages, 3 authors, 2017-04-24

Re: [PATCH v3 2/4] refs: introduce get_worktree_ref_store()

From: Duy Nguyen <hidden>
Date: 2017-03-20 12:31:23

On Mon, Mar 20, 2017 at 1:59 PM, Michael Haggerty [off-list ref] wrote:
I guess I can hold my nose and accept storing worktree and submodule
`ref_store`s together in a single hashmap
Release your nose, I'll add a new hashmap :) But while we're here,
what are your thoughts about moving submodule-specific to submodule.c?
That includes the hashmap, get_submodule_ref_store() and all other
submodule stuff, to submodule.c where submodule-specific stuff stays.
The same for worktree stuff, to worktree.c. That keeps refs.c to core
refs business. And the hashmap can be used for more than just refs.
For example, submodule has configs, and worktree also has bunch of
other stuff that I would like to just cache and not readdir() and
parse every time.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help