Thread (6 messages) flat view 6 messages, 2 authors, 2017-03-17

Re: [RFC PATCH 0/3] Git integration update for DC-SHA1

From: Jeff King <hidden>
Date: 2017-03-17 17:53:34

Possibly related (same subject, not in this thread)

On Fri, Mar 17, 2017 at 10:09:35AM -0700, Junio C Hamano wrote:
Here are three patches to replace the last two patches from your
series.

 - The Makefile knob is named DC_SHA1, not USE_SHA1DC; this is to
   keep it consistent with existing BLK_SHA1 and PPC_SHA1.

 - The CPP macro is called SHA1_DC, not SHA1_SHA1DC; again this is
   for consistency with SHA1_BLK and SHA1_PPC.

 - Switch the default from OpenSSL's implementation to DC_SHA1.
   Those who want OpenSSL's one can ask with OPENSSL_SHA1.
OK. DC_SHA1 exposed tothe user does look a little funny to me, but it is
at least consistent with the other names. The patches themselves look
obviously fine.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help