Re: [PATCH v2] config: preserve <subsection> case for one-shot config on the command line

On Tue, Feb 21, 2017 at 9:50 AM, Jeff King [off-list ref] wrote:

On Tue, Feb 21, 2017 at 09:17:07AM -0800, Junio C Hamano wrote:

quoted

 * Changes from v1:

   - update the comment before the second loop to find the last
     dot.

   - move two new tests into existing t1300 (at least for now).

   - make it clear that the second of the new tests check two
     aspects of "three level vars" by setting up the expectation for
     the first half near the actual tests and adding comments on
     what it tests before the second half.

Thanks, this addresses all of my (admittedly minor) concerns.

-Peff

This patch looks different than what I last looked at. I like it.
Though the manual search of the last dot instead of using
strrchr seems to be over-optimizing to me.
Anyway it is still very understandable.

Thanks,
Stefan