Thread (3 messages) 3 messages, 3 authors, 2017-02-21

Re: [PATCH v2] config: preserve <subsection> case for one-shot config on the command line

From: Jeff King <hidden>
Date: 2017-02-21 17:50:28

On Tue, Feb 21, 2017 at 09:17:07AM -0800, Junio C Hamano wrote:
 * Changes from v1:

   - update the comment before the second loop to find the last
     dot.

   - move two new tests into existing t1300 (at least for now).

   - make it clear that the second of the new tests check two
     aspects of "three level vars" by setting up the expectation for
     the first half near the actual tests and adding comments on
     what it tests before the second half.
Thanks, this addresses all of my (admittedly minor) concerns.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help