[PATCH v2 04/27] attr.c: explain the lack of attr-name syntax check in parse_attr()
flat view
STALE3537d
From: Brandon Williams <hidden>
Date: 2017-01-23 20:35:52
Subsystem:
the rest · Maintainer:
Linus Torvalds
Revision v2 of 3 in this series.
Revisions (3)
- v1 [diff vs current]
- v2 current
- v3 [diff vs current]
From: Junio C Hamano <redacted> Signed-off-by: Junio C Hamano <redacted> Signed-off-by: Stefan Beller <redacted> Signed-off-by: Brandon Williams <redacted> --- attr.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/attr.c b/attr.c
index 007f1a299..6b55a57ef 100644
--- a/attr.c
+++ b/attr.c@@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp, return NULL; } } else { + /* + * As this function is always called twice, once with + * e == NULL in the first pass and then e != NULL in + * the second pass, no need for invalid_attr_name() + * check here. + */ if (*cp == '-' || *cp == '!') { e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET; cp++;
--
2.11.0.483.g087da7b7c-goog