[PATCH 00/27] Revamp the attribute system; another round · Brandon Williams <hidden> · 2017-01-13
[PATCH 20/27] attr: change validity check for attribute names to use positive logic · Brandon Williams <hidden> · 2017-01-12
[PATCH 19/27] attr: pass struct attr_check to collect_some_attrs · Brandon Williams <hidden> · 2017-01-12
[PATCH 18/27] attr: retire git_check_attrs() API · Brandon Williams <hidden> · 2017-01-12
[PATCH 17/27] attr: convert git_check_attrs() callers to use the new API · Brandon Williams <hidden> · 2017-01-12
[PATCH 15/27] attr: (re)introduce git_check_attr() and struct attr_check · Brandon Williams <hidden> · 2017-01-12
[PATCH 16/27] attr: convert git_all_attrs() to use "struct attr_check" · Brandon Williams <hidden> · 2017-01-12
[PATCH 23/27] attr: remove maybe-real, maybe-macro from git_attr · Brandon Williams <hidden> · 2017-01-12
[PATCH 24/27] attr: tighten const correctness with git_attr and match_attr · Brandon Williams <hidden> · 2017-01-12
[PATCH 21/27] attr: use hashmap for attribute dictionary · Brandon Williams <hidden> · 2017-01-12
Re: [PATCH 21/27] attr: use hashmap for attribute dictionary · Stefan Beller <hidden> · 2017-01-18
Re: [PATCH 21/27] attr: use hashmap for attribute dictionary · Brandon Williams <hidden> · 2017-01-18
[PATCH 25/27] attr: store attribute stacks in hashmap · Brandon Williams <hidden> · 2017-01-12
Re: [PATCH 25/27] attr: store attribute stacks in hashmap · Stefan Beller <hidden> · 2017-01-18
Re: [PATCH 25/27] attr: store attribute stacks in hashmap · Brandon Williams <hidden> · 2017-01-18
Re: [PATCH 25/27] attr: store attribute stacks in hashmap · Stefan Beller <hidden> · 2017-01-18
[PATCH 22/27] attr: eliminate global check_all_attr array · Brandon Williams <hidden> · 2017-01-12
[PATCH 27/27] attr: reformat git_attr_set_direction() function · Brandon Williams <hidden> · 2017-01-12
[PATCH 26/27] attr: push the bare repo check into read_attr() · Brandon Williams <hidden> · 2017-01-12
[PATCH 13/27] attr.c: outline the future plans by heavily commenting · Brandon Williams <hidden> · 2017-01-13
[PATCH 12/27] Documentation: fix a typo · Brandon Williams <hidden> · 2017-01-13
[PATCH 01/27] commit.c: use strchrnul() to scan for one line · Brandon Williams <hidden> · 2017-01-13
[PATCH 02/27] attr.c: use strchrnul() to scan for one line · Brandon Williams <hidden> · 2017-01-13
[PATCH 11/27] attr.c: add push_stack() helper · Brandon Williams <hidden> · 2017-01-13
[PATCH 08/27] attr.c: tighten constness around "git_attr" structure · Brandon Williams <hidden> · 2017-01-13
[PATCH 14/27] attr: rename function and struct related to checking attributes · Brandon Williams <hidden> · 2017-01-13
[PATCH 06/27] attr.c: mark where #if DEBUG ends more clearly · Brandon Williams <hidden> · 2017-01-13
[PATCH 07/27] attr.c: simplify macroexpand_one() · Brandon Williams <hidden> · 2017-01-13
[PATCH 10/27] attr: support quoting pathname patterns in C style · Brandon Williams <hidden> · 2017-01-13
[PATCH 09/27] attr.c: plug small leak in parse_attr_line() · Brandon Williams <hidden> · 2017-01-13
[PATCH 04/27] attr.c: explain the lack of attr-name syntax check in parse_attr() · Brandon Williams <hidden> · 2017-01-13
[PATCH 05/27] attr.c: complete a sentence in a comment · Brandon Williams <hidden> · 2017-01-13
[PATCH 03/27] attr.c: update a stale comment on "struct match_attr" · Brandon Williams <hidden> · 2017-01-13
[PATCH v2 00/27] Revamp the attribute system; another round · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 01/27] commit.c: use strchrnul() to scan for one line · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 02/27] attr.c: use strchrnul() to scan for one line · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 03/27] attr.c: update a stale comment on "struct match_attr" · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 04/27] attr.c: explain the lack of attr-name syntax check in parse_attr() · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 05/27] attr.c: complete a sentence in a comment · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 07/27] attr.c: simplify macroexpand_one() · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 10/27] attr: support quoting pathname patterns in C style · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 12/27] Documentation: fix a typo · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 13/27] attr.c: outline the future plans by heavily commenting · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 09/27] attr.c: plug small leak in parse_attr_line() · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 11/27] attr.c: add push_stack() helper · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 14/27] attr: rename function and struct related to checking attributes · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 20/27] attr: change validity check for attribute names to use positive logic · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 21/27] attr: use hashmap for attribute dictionary · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 22/27] attr: eliminate global check_all_attr array · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 16/27] attr: convert git_all_attrs() to use "struct attr_check" · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 23/27] attr: remove maybe-real, maybe-macro from git_attr · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 24/27] attr: tighten const correctness with git_attr and match_attr · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 17/27] attr: convert git_check_attrs() callers to use the new API · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 18/27] attr: retire git_check_attrs() API · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 15/27] attr: (re)introduce git_check_attr() and struct attr_check · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 06/27] attr.c: mark where #if DEBUG ends more clearly · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 08/27] attr.c: tighten constness around "git_attr" structure · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 19/27] attr: pass struct attr_check to collect_some_attrs · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 26/27] attr: push the bare repo check into read_attr() · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 27/27] attr: reformat git_attr_set_direction() function · Brandon Williams <hidden> · 2017-01-23
[PATCH v2 25/27] attr: store attribute stack in attr_check structure · Brandon Williams <hidden> · 2017-01-23
[PATCH v3 00/27] Revamp the attribute system; another round · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 01/27] commit.c: use strchrnul() to scan for one line · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 02/27] attr.c: use strchrnul() to scan for one line · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 05/27] attr.c: complete a sentence in a comment · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 03/27] attr.c: update a stale comment on "struct match_attr" · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 07/27] attr.c: simplify macroexpand_one() · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 06/27] attr.c: mark where #if DEBUG ends more clearly · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 08/27] attr.c: tighten constness around "git_attr" structure · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 04/27] attr.c: explain the lack of attr-name syntax check in parse_attr() · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 09/27] attr.c: plug small leak in parse_attr_line() · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 10/27] attr: support quoting pathname patterns in C style · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 11/27] attr.c: add push_stack() helper · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 12/27] Documentation: fix a typo · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 15/27] attr: (re)introduce git_check_attr() and struct attr_check · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 15/27] attr: (re)introduce git_check_attr() and struct attr_check · Brandon Williams <hidden> · 2017-01-30
[PATCH v3 13/27] attr.c: outline the future plans by heavily commenting · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 16/27] attr: convert git_all_attrs() to use "struct attr_check" · Brandon Williams <hidden> · 2017-01-28
Re: [PATCH v3 16/27] attr: convert git_all_attrs() to use "struct attr_check" · Stefan Beller <hidden> · 2017-01-28
Re: [PATCH v3 16/27] attr: convert git_all_attrs() to use "struct attr_check" · Brandon Williams <hidden> · 2017-01-29
[PATCH v3 16/27] attr: convert git_all_attrs() to use "struct attr_check" · Brandon Williams <hidden> · 2017-01-30
[PATCH v3 14/27] attr: rename function and struct related to checking attributes · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 18/27] attr: retire git_check_attrs() API · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 19/27] attr: pass struct attr_check to collect_some_attrs · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 17/27] attr: convert git_check_attrs() callers to use the new API · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 22/27] attr: eliminate global check_all_attr array · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 21/27] attr: use hashmap for attribute dictionary · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 26/27] attr: push the bare repo check into read_attr() · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 25/27] attr: store attribute stack in attr_check structure · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 20/27] attr: change validity check for attribute names to use positive logic · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 24/27] attr: tighten const correctness with git_attr and match_attr · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 27/27] attr: reformat git_attr_set_direction() function · Brandon Williams <hidden> · 2017-01-28
[PATCH v3 23/27] attr: remove maybe-real, maybe-macro from git_attr · Brandon Williams <hidden> · 2017-01-28

Re: [PATCH 21/27] attr: use hashmap for attribute dictionary

From: Brandon Williams <hidden>
Date: 2017-01-18 20:30:46

On 01/18, Stefan Beller wrote:

On Thu, Jan 12, 2017 at 3:53 PM, Brandon Williams [off-list ref] wrote:

quoted

+/* Initialize an 'attr_hashmap' object */
+void attr_hashmap_init(struct attr_hashmap *map)

In case a reroll is needed, mark this static please.

Will do.

-- 
Brandon Williams

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help