Thread (22 messages) flat view 22 messages, 4 authors, 2017-01-18

Re: [PATCH 5/5] describe: teach describe negative pattern matches

From: Jacob Keller <hidden>
Date: 2017-01-13 06:58:16

On Thu, Jan 12, 2017 at 10:43 PM, Johannes Sixt [off-list ref] wrote:
Am 13.01.2017 um 01:59 schrieb Jacob Keller:
quoted
I think that --exclude makes sense, but the current implementation
does not differentiate ordering, since both are merely accumulated
into string_lists and then matched together. I'm not sure how order
would impact things here? In the current implementation, if something
is excluded and matched, it will be excluded. That is, exclusion
patterns take precedence over match patterns. I think this makes the
most sense semantically.

When you write

  git log --exclude=wip/* --branches --remotes

--exclude applies only to --branches, not to --remotes.

 When you write

  git log --branches --exclude=origin/* --remotes

--exclude=origin/* applies only to --remotes, but not to --branches.

-- Hannes
Well for describe I don't think the order matters.

Thanks,
Jake
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help