Thread (29 messages) flat view 29 messages, 5 authors, 2016-12-01

Re: What's cooking in git.git (Nov 2016, #06; Mon, 28)

From: Brandon Williams <hidden>
Date: 2016-12-01 01:21:55

On 11/30, Stefan Beller wrote:
quoted
Oh interesting, I wonder if there is a way to not have to perform a
chdir since taking a lock to lstat wouldn't be ideal.
I think we could rewrite is_submodule_populated to be

int is_submodule_populated_cheap_with_no_chdir(char *path)
{
    return stat(path + ".git")
}

i.e. just take the presence of the .git file/dir as a hint to run
the child process?
I like this approach, its a quick (thread-safe) check to see if the
submodule is interesting.  If there happens to be an error with the
submodule's .git file/directory then the child process will fail out.

-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help