-----Original Message-----
From: Stefan Beller [mailto:sbeller@google.com]

quoted

quoted

+                             if (submodule_is_interesting(old->name,

null_sha1)

quoted

quoted

+                                 && ok_to_remove_submodule(old->name))
+                                     return 0;
+                     }

Do we need a return 1 in here somewhere?  Because otherwise, we fall

through and return 0 later.

Otherwise we would fall through and run

    if (errno == ENOENT)
        return 0;
    return o->gently ? -1 :
        add_rejected_path(o, error_type, ce->name);

which produces different results than 0?

Oh, I see.  I was misreading that errno check.