Thread (26 messages) flat view 26 messages, 5 authors, 2016-11-16

Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS

From: Lars Schneider <hidden>
Date: 2016-11-10 11:07:22

On 07 Nov 2016, at 22:20, Jeff King [off-list ref] wrote:

On Sun, Nov 06, 2016 at 10:42:36PM +0100, Lars Schneider wrote:
quoted
quoted
From: Lars Schneider <redacted>

TravisCI changed their default macOS image from 10.10 to 10.11 [1].
Unfortunately the HTTPD tests do not run out of the box using the
pre-installed Apache web server anymore. Therefore we enable these
tests only for Linux and disable them for macOS.
[...]
Hi Junio,

the patch above is one of two patches to make TravisCI pass, again.
Could you queue it?
I don't really mind disabling tests if they don't run on a platform. But
the more interesting question to me is: why don't they run any more? Is
there some config tweak needed, or is it an insurmountable problem?
I can't really remember what the problem was. I think some apache config
required some module that was not present and I wasn't able to get this
working quickly.

Using Apache in the tests has been the source of frequent portability
problems and configuration headaches. I do wonder if we'd be better off
using some small special-purpose web server (even a short perl script
written around HTTP::Server::Simple or something).

On the other hand, testing against Apache approximates a more real-world
case, which has value. It might be nice if our tests supported multiple
web servers, but that would mean duplicating the config for each
manually.
I agree that the real-world Apache test is more valuable and I really want
to keep the Linux Apache test running. However, I don't think many people
use macOS as Git web server and therefore I thought it is not worth the
effort to investigate this problem further.

- Lars
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help