Re: [PATCH v1 1/2] config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11
From: Jeff King <hidden>
Date: 2016-11-07 17:26:24
On Sun, Nov 06, 2016 at 08:35:04PM +0100, Lars Schneider wrote:
quoted hunk ↗ jump to hunk
Good point. I think I found an even easier way to achieve the same. What do you think about the patch below? [...]diff --git a/Makefile b/Makefile index 9d6c245..f53fcc9 100644 --- a/Makefile +++ b/Makefile@@ -1047,6 +1047,7 @@ ifeq ($(uname_S),Darwin) endif endif ifndef NO_APPLE_COMMON_CRYPTO + NO_OPENSSL = YesPlease APPLE_COMMON_CRYPTO = YesPlease COMPAT_CFLAGS += -DAPPLE_COMMON_CRYPTO endif
That is much simpler. I have in the back of my mind a fear that it is harder to unset a make variable than it is to override it with a new value (which is what you'd want to do here to turn openssl back on), but I can't seem to come up with a case that doesn't work. So I am probably misremembering, or just thinking of something that used to be a problem long ago. -Peff