Thread (39 messages) 39 messages, 3 authors, 2016-11-09

Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

From: Christian Couder <hidden>
Date: 2016-10-29 22:20:08

On Tue, Oct 25, 2016 at 12:00 PM, Duy Nguyen [off-list ref] wrote:
On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder
[off-list ref] wrote:
quoted
When users are using `git update-index --(no-)split-index`, they
may expect the split-index feature to be used or not according to
the option they just used, but this might not be the case if the
new "core.splitIndex" config variable has been set. In this case
let's warn about what will happen and why.

Signed-off-by: Christian Couder <redacted>
---
 builtin/update-index.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/builtin/update-index.c b/builtin/update-index.c
index b75ea03..a14dbf2 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -1098,12 +1098,21 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
        }

        if (split_index > 0) {
+               if (git_config_get_split_index() == 0)
+                       warning("core.splitIndex is set to false; "
+                               "remove or change it, if you really want to "
+                               "enable split index");
Wrap this string and the one below with _() so they can be translated.
Ok, it will be in the next version.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help