Re: [PATCH v8 08/11] convert: quote filter names in error messages

W dniu 20.09.2016 o 21:02, larsxschneider@gmail.com pisze:

From: Lars Schneider <redacted>

Git filter driver commands with spaces (e.g. `filter.sh foo`) are hard
to read in error messages. Quote them to improve the readability.

Signed-off-by: Lars Schneider <redacted>
---
 convert.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Looks good (those are all sites matching 'error.*%s' in convert.c).

-		return error("cannot fork to run external filter %s", params->cmd);
+		return error("cannot fork to run external filter '%s'", params->cmd);

-		error("cannot feed the input to external filter %s", params->cmd);
+		error("cannot feed the input to external filter '%s'", params->cmd);

-		error("external filter %s failed %d", params->cmd, status);
+		error("external filter '%s' failed %d", params->cmd, status);

-		error("read from external filter %s failed", cmd);
+		error("read from external filter '%s' failed", cmd);

-		error("read from external filter %s failed", cmd);
+		error("read from external filter '%s' failed", cmd);

-		error("external filter %s failed", cmd);
+		error("external filter '%s' failed", cmd);