Thread (63 messages) 63 messages, 2 authors, 2016-09-09

Re: [PATCH 09/15] sequencer: lib'ify create_seq_dir()

From: Johannes Schindelin <hidden>
Date: 2016-08-24 15:59:03

Hi Eric,

On Wed, 24 Aug 2016, Eric Sunshine wrote:
On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin
[off-list ref] wrote:
quoted
To be truly useful, the sequencer should never die() but always return
an error.

Signed-off-by: Johannes Schindelin <redacted>
---
diff --git a/sequencer.c b/sequencer.c
@@ -839,8 +839,8 @@ static int create_seq_dir(void)
                return -1;
        }
        else if (mkdir(git_path_seq_dir(), 0777) < 0)
-               die_errno(_("Could not create sequencer directory %s"),
-                         git_path_seq_dir());
+               return error(_("Could not create sequencer directory %s (%s)"),
+                         git_path_seq_dir(), strerror(errno));
error_errno()?
Yep!

Thanks,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help