Re: [PATCH 06/15] sequencer: lib'ify read_populate_todo()

Hi Eric,

On Wed, 24 Aug 2016, Eric Sunshine wrote:

On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin
[off-list ref] wrote:

quoted

To be truly useful, the sequencer should never die() but always return
an error.

Signed-off-by: Johannes Schindelin <redacted>
---

diff --git a/sequencer.c b/sequencer.c

@@ -754,18 +754,21 @@ static void read_populate_todo(struct commit_list **todo_list,

        fd = open(git_path_todo_file(), O_RDONLY);
        if (fd < 0)
-               die_errno(_("Could not open %s"), git_path_todo_file());
+               return error(_("Could not open %s (%s)"),
+                       git_path_todo_file(), strerror(errno));

error_errno() perhaps?

Absolutely!

Thanks,
Dscho